Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16422#discussion_r94199552
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
* Create a [[DescribeTableCommand]] logical plan.
*/
override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan
= withOrigin(ctx) {
- // Describe column are not supported yet. Return null and let the
parser decide
- // what to do with this (create an exception or pass it on to a
different system).
if (ctx.describeColName != null) {
- null
+ if (ctx.partitionSpec != null) {
+ throw new ParseException("DESC TABLE COLUMN for a specific
partition is not supported", ctx)
+ } else {
+ val columnName = ctx.describeColName.getText
--- End diff --
the parser rule for the column name here:
```
describeColName
: identifier ('.' (identifier | STRING))*
;
```
can we just make it `identifier`? "a.b" should refer to a column named
"a.b", or the inner field "b" from column "a"? let's check with other databases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
