Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r94202164
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -845,6 +846,7 @@ private[hive] class HiveClientImpl(
table.comment.foreach { c => hiveTable.setProperty("comment", c) }
table.viewOriginalText.foreach { t => hiveTable.setViewOriginalText(t)
}
table.viewText.foreach { t => hiveTable.setViewExpandedText(t) }
+ table.viewDefaultDatabase.foreach {t =>
hiveTable.setProperty("viewDefaultDatabase", t)}
--- End diff --
First, we should define `viewDefaultDatabase ` in the object
`HiveExternalCatalog`. See the
[examples](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L1059-L1083).
Second, we do not convert the table properties here. Normally, all the
table properties should be converted in
[`restoreTableMetadata`](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L615).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
