Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2287#discussion_r17210951
--- Diff: python/pyspark/tests.py ---
@@ -181,6 +181,18 @@ def tearDown(self):
sys.path = self._old_sys_path
+# Regression test for SPARK-3415
+class CloudPickleTestCase(PySparkTestCase):
--- End diff --
One final naming nit: so far, the classes named `*TestCase` are used for
factoring out common setup / teardown code (such as `unittest.TestCase`,
`PySparkTestCase`, etc.), while the classes with the actual tests have been
called `[ComponentName]Tests` or `Test[ComponentName]`. Therefore, I'd prefer
to call this `CloudPickleTests`.
Also, since this is just testing CloudPickle without using any PySpark
features, it should extend `unittest.TestCase` instead of `PySparkTestCase` so
that we don't run a setup / teardown method for a SparkContext that we never
use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
