Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16377#discussion_r94288852
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -57,6 +58,29 @@ class DecisionTreeRegressorSuite
compareAPIs(categoricalDataPointsRDD, dt, categoricalFeatures)
}
+ test("SPARK-18036: Verify Decision Tree regression throws" +
--- End diff --
Take a look at [this
test](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala#L164).
It should have failed before, but it didn't due to how we handle different
types of features differently.
I prefer not to add tests to each of DecisionTree, GBT, RF suites, and
instead add a single test to `RandomForestSuite` which exercises constant
features with both exclusively continuous features and a mixture of ordered
categorical, unordered categorical, and continuous features.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
