Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16451#discussion_r94575201
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
---
@@ -138,10 +139,15 @@ class KafkaTestUtils extends Logging {
if (server != null) {
server.shutdown()
+ server.awaitShutdown()
server = null
}
- brokerConf.logDirs.foreach { f => Utils.deleteRecursively(new File(f))
}
+ // On Windows, `logDirs` is left open even after Kafka server above is
completely shut-downed
+ // in some cases. It leads to test failures on Windows if these are
not ignored.
+ brokerConf.logDirs.map(new File(_))
+ .filterNot(FileUtils.deleteQuietly)
--- End diff --
Ah, actually, `_.delete` does not actually delete when it is not empty as
below:
```
.
âââ tmp
âââ aa
```
```scala
scala> import java.io.File
import java.io.File
scala> new File("./tmp").delete()
res0: Boolean = false
```
I first wanted to use `Utils.deleteRecursively` but it throws an exception
as below:
```
DirectKafkaStreamSuite:
Exception encountered when attempting to run a suite with class name:
org.apache.spark.streaming.kafka.DirectKafkaStreamSuite *** ABORTED *** (7
seconds, 127 milliseconds)
java.io.IOException: Failed to delete:
C:\projects\spark\target\tmp\spark-d0d3eba7-4215-4e10-b40e-bb797e89338e
at org.apache.spark.util.Utils$.deleteRecursively(Utils.scala:1010)
```
when a lock is hold on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
