Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94771634
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -158,6 +183,16 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
setDefault(family -> Gaussian.name)
/**
+ * Sets the value of param [[variancePower]].
+ * Used only when family is "tweedie".
+ *
+ * @group setParam
+ */
+ @Since("2.2.0")
+ def setVariancePower(value: Double): this.type = set(variancePower,
value)
+ setDefault(variancePower -> 1.5)
--- End diff --
Why set the default value to 1.5, AFAIK, R set the default
```variancePower``` with 0 which means gaussian family, and identity as default
link function.
```
glm(formula = "b ~ .", family = tweedie, data = df, weights = w)
```
produces the same model with
```
glm(formula = "b ~ .", family = gaussian, data = df, weights = w)
```
[h2o.glm](https://rdrr.io/cran/h2o/man/h2o.glm.html) has the consistent
default values with R, should we keep consistent with them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
