GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/16479
[SPARK-19085][SQL] cleanup OutputWriterFactory and OutputWriter
## What changes were proposed in this pull request?
`OutputWriterFactory`/`OutputWriter` are internal interfaces and we can
remove some unnecessary APIs:
1. `OutputWriterFactory.newWriter(path: String)`: no one calls it and no
one implements it.
2. `OutputWriter.write(row: Row): Unit`: during execution we only call
`writeInternal`, which is weird as `OutputWriter` is already an internal
interface. We should rename `writeInternal` to `write` and remove `def
write(row: Row): Unit` and it's related converter code. All implementations
should just implement `def write(row: InternalRow): Unit`
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark hive-writer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16479
----
commit 1de8e4946ed1f0c1ae5738b872acb6b995a8295f
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2017-01-05T15:56:28Z
cleanup OutputWriterFactory and OutputWriter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
