Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/2301#discussion_r17218890
--- Diff: bin/spark-class ---
@@ -105,7 +105,7 @@ else
exit 1
fi
fi
-JAVA_VERSION=$($RUNNER -version 2>&1 | sed 's/java version
"\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
+JAVA_VERSION=$($RUNNER -version 2>&1 | sed 's/java\|openjdk version
"\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
--- End diff --
This regex seems wrong.. it now breaks the case when you print "java
version X". You need parens around the (`java\|openjdk`). Also, are you sure
that OpenJDK 1.8 prints this string instead of "java version X"? I tried 1.6
and it still prints "java".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
