Github user srowen commented on the issue: https://github.com/apache/spark/pull/16475 I'm not sure about this. The `getBlockData` method handles both the shuffle/non-shuffle case separately too -- and will actually call back to `getLocalBytes`. It is probably OK now, and won't result in an infinite recursion, but is a distant problem waiting to happen. It looks like this method also purposely intends to handle the shuffle case manually, itself. I don't know that this is an unambiguously good refactoring so would not make this change.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org