Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16480#discussion_r94860559
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
    @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (
           multiclassLabeled.unpersist()
         }
     
    +    val instrLog = Instrumentation.create(this, multiclassLabeled)
    --- End diff --
    
    Btw, can you please rename this to "instr" to match other classes?  I see 
ALS is also named instrLog, but it's the only one.  Could you change ALS to 
"instr" as well in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to