Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16474#discussion_r94892533
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -593,13 +650,10 @@ object ParquetFileFormat extends Logging {
new FileStatus(length, false, 0, 0, 0, 0, null, null, null,
new Path(path))
}.toSeq
- // Skips row group information since we only need the schema
- val skipRowGroups = true
-
// Reads footers in multi-threaded manner within each task
val footers =
- ParquetFileReader.readAllFootersInParallel(
- serializedConf.value, fakeFileStatuses.asJava,
skipRowGroups).asScala
+ ParquetFileFormat.readParquetFootersInParallel(
--- End diff --
Can we add some unit tests for readParquetFootersInParallel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
