Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14451#discussion_r94903231
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -536,10 +539,17 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
*/
@scala.annotation.varargs
def textFile(paths: String*): Dataset[String] = {
+ assertNoSpecifiedSchema("textFile")
+ text(paths :
_*).select("value").as[String](sparkSession.implicits.newStringEncoder)
+ }
+
+ /**
+ * A convenient function for schema validation in APIs.
+ */
+ private def assertNoSpecifiedSchema(operation: String): Unit = {
if (userSpecifiedSchema.nonEmpty) {
- throw new AnalysisException("User specified schema not supported
with `textFile`")
+ throw new AnalysisException(s"User specified schema not supported
with `$operation`")
}
- text(paths :
_*).select("value").as[String](sparkSession.implicits.newStringEncoder)
--- End diff --
This prints weird.. I just added
```scala
/**
* A convenient function for schema validation in APIs.
*/
private def assertNoSpecifiedSchema(operation: String): Unit = {
if (userSpecifiedSchema.nonEmpty) {
throw new AnalysisException(s"User specified schema not supported
with `$operation`")
}
}
```
at the end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
