Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16440#discussion_r94986837
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -309,6 +309,12 @@ object SQLConf {
         .stringConf
         .createOptional
     
    +  val THRIFTSERVER_INCREMENTAL_COLLECT =
    --- End diff --
    
    I think this makes this option for "public"; I see some other options here 
marked as `.internal()`. I don't know whether this is meant to be further 
exposed. It might be more conservative to make it internal for the moment? but 
yes seems sensible to make a config key constant like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to