GitHub user imatiach-msft opened a pull request:

    https://github.com/apache/spark/pull/16494

    [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with ClassCastException

    ## What changes were proposed in this pull request?
    
    LDA fails with a ClassCastException when run on a dataset with at least one 
row that contains an empty sparse vector.  The error occurs in method fromEdges 
where one of the edges may already be an EdgeRDDImpl and it does not need to be 
converted.
    
    ## How was this patch tested?
    
    I first ran LDA on the dataset provided by the JIRA submitter and I was 
able to reproduce the issue.  I then fixed the issue based on the submitter's 
suggestion and simplified the test case so that we wouldn't need to read in a 
file.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/imatiach-msft/spark ilmat/fix-EMLDA

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16494
    
----
commit 0a201b713276b92a20db330ccd20b9a562694f5a
Author: Ilya Matiach <il...@microsoft.com>
Date:   2017-01-06T21:36:19Z

    adding test case to reproduce the error

commit 66dbfea60fec23fb8b39e23adf1861cfa02d7d42
Author: Ilya Matiach <il...@microsoft.com>
Date:   2017-01-07T00:42:49Z

    [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with ClassCastException

commit 0d1c475c80a6fd0373108610ca8e41f7af0e6d01
Author: Ilya Matiach <il...@microsoft.com>
Date:   2017-01-07T01:04:40Z

    Optimizing test case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to