Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/16476#discussion_r95055087
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala
---
@@ -137,4 +139,48 @@ class ConditionalExpressionSuite extends SparkFunSuite
with ExpressionEvalHelper
checkEvaluation(CaseKeyWhen(c6, Seq(c5, c2, c4, c3)), null, row)
checkEvaluation(CaseKeyWhen(literalNull, Seq(c2, c5, c1, c6)), null,
row)
}
+
+ test("case field") {
--- End diff --
I feel like you have comprehensive testing but at the same time feels like
there is overlap amongst the tests in terms of coverage. There is room of
reducing the tests while still having same coverage. eg you don't need 5
strings and use lesser.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
