Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95074140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -91,10 +111,19 @@ case class Percentile(
case _ => DoubleType
}
- override def inputTypes: Seq[AbstractDataType] =
percentageExpression.dataType match {
- case _: ArrayType => Seq(NumericType, ArrayType(DoubleType))
- case _ => Seq(NumericType, DoubleType)
- }
+ override def inputTypes: Seq[AbstractDataType] =
+ if (frequency == unit) {
+ percentageExpression.dataType match {
+ case _: ArrayType => Seq(NumericType, ArrayType(DoubleType))
+ case _ => Seq(NumericType, DoubleType)
+ }
+ } else {
+ percentageExpression.dataType match {
--- End diff --
It is not needed to make a difference between freq = 1 and the freq > 1
cases. Just use the more complete case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
