Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16312#discussion_r95074414
--- Diff: R/pkg/R/mllib_utils.R ---
@@ -81,9 +80,11 @@ predict_internal <- function(object, newData) {
#' model <- read.ml(path)
#' }
#' @note read.ml since 2.0.0
-read.ml <- function(path, sparkSession = NULL) {
+read.ml <- function(path) {
path <- suppressWarnings(normalizePath(path))
- jobj <- callJStatic("org.apache.spark.ml.r.RWrappers", "load", path,
sparkSession)
+ sparkSession <- getSparkSession()
+ callJStatic("org.apache.spark.ml.r.RWrappers", "session", sparkSession)
--- End diff --
Here we call ```session``` method to set spark session, the function name
is really confusing, may be named as ```setSession``` should be better, but we
use the current name from the very beginning.
There is no other places need to be updated, since here is the only place
calling ```RWrappers```. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
