Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16501#discussion_r95077902
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
---
@@ -226,7 +226,8 @@ abstract class HiveComparisonTest
testCaseName: String,
sql: String,
reset: Boolean = true,
- tryWithoutResettingFirst: Boolean = false) {
+ tryWithoutResettingFirst: Boolean = false,
+ assumption: Boolean = true) {
--- End diff --
I think this is OK, but might be more natural to either: call the parameter
"skip" or something, and assume(!skip), or else, make it a function `() =>
Boolean` that the test actually tests later? calling the boolean result the
assumption is a little funny.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
