Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95286413
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") (
val numFeatures = oldDataset.first().features.size
val boostingStrategy =
super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification)
- val instr = Instrumentation.create(this, oldDataset)
+ val numClasses: Int = getNumClasses(dataset)
+ if (isDefined(thresholds)) {
--- End diff --
I prefer to leave the handling of thresholds for another JIRA, but
technically users will be able to set it. We can either do it here in this PR,
or throw an error until we get it implemented in a follow up. Thoughts
@jkbradley?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
