Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95309134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object GenerateOrdering extends
CodeGenerator[Seq[SortOrder], Ordering[InternalR
}
}
"""
- }.mkString("\n")
- comparisons
+ }
+
+ ctx.splitExpressions(
+ expressions = comparisons,
+ funcName = "compare",
+ arguments = Seq(("InternalRow", "a"), ("InternalRow", "b")),
+ returnType = "int",
+ makeSplitFunction = { body =>
+ s"""
+ InternalRow ${ctx.INPUT_ROW} = null; // Holds current row being
evaluated.
+ $body
+ return 0;
+ """
+ },
+ foldFunctions = { funCalls =>
+ val comp = ctx.freshName("comp")
+ funCalls.zipWithIndex.map { case (funCall, i) =>
+ s"""
+ int ${comp}_$i = $funCall;
--- End diff --
oh sorry, we should put the `freshName` in the map function
```
funCalls.zipWithIndex.map { case (funCall, i) =>
val comp = ctx.freshName("comp")
s"""
int $comp = $funCall;
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
