Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16511#discussion_r95377113
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -104,8 +106,9 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
weightCol <- ""
}
+ # For known families, Gamma is upper-cased
jobj <-
callJStatic("org.apache.spark.ml.r.GeneralizedLinearRegressionWrapper",
- "fit", formula, data@sdf, family$family,
family$link,
+ "fit", formula, data@sdf,
tolower(family$family), family$link,
--- End diff --
I think we need take some time to get MLlib side changed (and it involves
changes for other estimators). Sounds good to keep the R side change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
