Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16522#discussion_r95414967
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
    @@ -94,7 +94,13 @@ private[sql] trait SQLTestUtils
        */
       protected def withSQLConf(pairs: (String, String)*)(f: => Unit): Unit = {
         val (keys, values) = pairs.unzip
    -    val currentValues = keys.map(key => Try(spark.conf.get(key)).toOption)
    +    val currentValues = keys.map { key =>
    --- End diff --
    
    I think this can just be `keys.flatMap(conf.get)`. But I'll let Ryan look 
since he's more involved with this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to