Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16376#discussion_r95424970
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -54,7 +54,7 @@ import org.apache.spark.util.{AccumulatorV2, ThreadUtils,
Utils}
private[spark] class TaskSchedulerImpl private[scheduler](
val sc: SparkContext,
val maxTaskFailures: Int,
- blacklistTrackerOpt: Option[BlacklistTracker],
+ val blacklistTrackerOpt: Option[BlacklistTracker],
--- End diff --
doh, actually this is used in tests. I override `createTaskSetManager` to
use my manual clock. Another alternative is to allow the clock to get passed
in to the `TaskSCheudlerImpl` constructor, but that ends up being a bigger code
change.
I'll make it `private[scheduler] val`, slightly tighter than the implicit
`private[spark]` it would be otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
