Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95421315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -767,19 +857,19 @@ class Analyzer(
}
}
- /**
- * In many dialects of SQL it is valid to use ordinal positions in
order/sort by and group by
- * clauses. This rule is to convert ordinal positions to the
corresponding expressions in the
- * select list. This support is introduced in Spark 2.0.
- *
- * - When the sort references or group by expressions are not integer but
foldable expressions,
- * just ignore them.
- * - When spark.sql.orderByOrdinal/spark.sql.groupByOrdinal is set to
false, ignore the position
- * numbers too.
- *
- * Before the release of Spark 2.0, the literals in order/sort by and
group by clauses
- * have no effect on the results.
- */
+ /**
+ * In many dialects of SQL it is valid to use ordinal positions in
order/sort by and group by
+ * clauses. This rule is to convert ordinal positions to the
corresponding expressions in the
+ * select list. This support is introduced in Spark 2.0.
+ *
+ * - When the sort references or group by expressions are not integer
but foldable expressions,
+ * just ignore them.
+ * - When spark.sql.orderByOrdinal/spark.sql.groupByOrdinal is set to
false, ignore the position
+ * numbers too.
+ *
+ * Before the release of Spark 2.0, the literals in order/sort by and
group by clauses
+ * have no effect on the results.
+ */
--- End diff --
what's going on with these lines?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
