Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16528#discussion_r95431635
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala ---
    @@ -187,82 +189,169 @@ abstract class Catalog {
       def functionExists(dbName: String, functionName: String): Boolean
     
       /**
    -   * :: Experimental ::
    -   * Creates an external table from the given path and returns the 
corresponding DataFrame.
    +   * Creates a table from the given path and returns the corresponding 
DataFrame.
        * It will use the default data source configured by 
spark.sql.sources.default.
        *
        * @since 2.0.0
        */
    +  @deprecated("use createTable instead.", "2.2.0")
    +  def createExternalTable(tableName: String, path: String): DataFrame = {
    +    createTable(tableName, path)
    +  }
    +
    +  /**
    +   * :: Experimental ::
    +   * Creates a table from the given path and returns the corresponding 
DataFrame.
    --- End diff --
    
    Maybe we can explain here to say the data files will not be dropped when 
dropping the table?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to