Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16523#discussion_r95432626
  
    --- Diff: R/pkg/R/mllib_clustering.R ---
    @@ -204,11 +208,16 @@ setMethod("write.ml", signature(object = 
"GaussianMixtureModel", path = "charact
     #' @note spark.kmeans since 2.0.0
     #' @seealso \link{predict}, \link{read.ml}, \link{write.ml}
     setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = 
"formula"),
    -          function(data, formula, k = 2, maxIter = 20, initMode = 
c("k-means||", "random")) {
    +          function(data, formula, k = 2, maxIter = 20, initMode = 
c("k-means||", "random"),
    +                   seed = NULL, initSteps = 2, tol = 1E-4) {
                 formula <- paste(deparse(formula), collapse = "")
                 initMode <- match.arg(initMode)
    +            if (!is.null(seed)) {
    +              seed <- as.character(as.integer(seed))
    --- End diff --
    
    as you call out, R does not natively support 64bit integer. I think we are 
pretty much stuck here since the user won't be able to pass in a 64bit integer. 
We could explore making this a string but I really think that is hard to use.
    
    the reason this is a string on the JVM side is because we want to support 
default seed value when it is unset (which is passed as NULL)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to