Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16537#discussion_r95484684
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -429,6 +429,11 @@ def test_udf_with_input_file_name(self):
             row = 
self.spark.read.json(filePath).select(sourceFile(input_file_name())).first()
             self.assertTrue(row[0].find("people1.json") != -1)
     
    +    def test_udf_should_validate_input_args(self):
    +        from pyspark.sql.functions import udf
    +
    +        self.assertRaises(TypeError, udf(lambda x: x), None)
    --- End diff --
    
    I think this should have positive tests for a column and a string as well 
as a negative test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to