Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r95495553
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -20,6 +20,12 @@ package org.apache.spark.mllib.tree.loss
import org.apache.spark.annotation.{DeveloperApi, Since}
import org.apache.spark.mllib.util.MLUtils
+/**
+ * Trait for adding probability function for the gradient boosting
algorithm.
--- End diff --
nit: Doc is too specific. It's a trait for classification loss, not
necessarily just for adding a prob func. I'm not sure we need a doc here.
Actually we could add a doc to the `computeProbability` method saying that it
computes the class probability given the margin, if that's unclear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
