Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16233#discussion_r95526238
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -378,6 +379,35 @@ case class InsertIntoTable(
     }
     
     /**
    + * A container for holding the view description(CatalogTable), and the 
output of the view. The
    + * child should be a logical plan parsed from the `CatalogTable.viewText`, 
should throw an error
    + * if the `viewText` is not defined.
    + * This operator will be removed at the end of analysis stage.
    + *
    + * @param desc A view description(CatalogTable) that provides necessary 
information to resolve the
    + *             view.
    + * @param output The output of a view operator, this is generated during 
planning the view, so that
    + *               we are able to decouple the output from the underlying 
structure.
    + * @param child The logical plan of a view operator, it should be a 
logical plan parsed from the
    + *              `CatalogTable.viewText`, should throw an error if the 
`viewText` is not defined.
    + */
    +case class View(
    +    desc: CatalogTable,
    +    output: Seq[Attribute],
    +    child: LogicalPlan) extends LogicalPlan with MultiInstanceRelation {
    --- End diff --
    
    We only extend `MultiInstanceRelation` for the leaf node. Any reason why it 
is needed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to