Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2285#discussion_r17261491
  
    --- Diff: dev/mima ---
    @@ -25,11 +25,15 @@ FWDIR="$(cd `dirname $0`/..; pwd)"
     cd "$FWDIR"
     
     echo -e "q\n" | sbt/sbt oldDeps/update
    +rm -f .generated-mima*
    +
    +./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
    --- End diff --
    
    does this need to be called twice? It's now called here and below as well. 
If it is needed twice, it would be good to document why,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to