Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16549#discussion_r95716715
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -1340,8 +1348,8 @@ class HiveDDLSuite
           val e3 = intercept[AnalysisException] {
             
spark.table("t").write.format("hive").mode("overwrite").saveAsTable("t")
           }
    -      assert(e3.message.contains(
    -        "CTAS for hive serde tables does not support append or overwrite 
semantics"))
    +      assert(e3.message.contains("Cannot overwrite table")
    +        && e3.message.contains("that is also being read from"))
    --- End diff --
    
    nit: we can test the full message `Cannot overwrite table default.t that is 
also being read from`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to