Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2259#issuecomment-54890949
One general issue, not specifically related to this patch but still worth
fixing, is thread-safety for the collections in PythonWorkerFactory. It looks
like there's not proper synchronization on accesses to some of these
collections, while others are inconsistently synchronized (sometimes guarded by
PythonWorkerFactory's `synchronized` and sometimes synchronized on the
collection itself). It would be nice to clean this up in a consistent way,
either by always synchronizing PythonWorkerFactory's public methods on the
object itself or by exclusively using finer-grained synchronization on
individual collections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
