Github user michalsenkyr commented on a diff in the pull request:
https://github.com/apache/spark/pull/16546#discussion_r95927063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -120,6 +120,32 @@ object ScalaReflection extends ScalaReflection {
}
/**
+ * Returns the element type for Seq[_] and its subclass.
+ */
+ def getElementTypeForSeq(t: `Type`): Option[`Type`] = {
+ if (!(t <:< localTypeOf[Seq[_]])) {
+ return None
+ }
+ val TypeRef(_, _, elementTypeList) = t
--- End diff --
This would probably be better solved by using `match` and `typeParams`.
Something like this:
```scala
t match {
case TypeRef(_, _, Seq(elementType)) => Some(elementType)
case _ =>
t.baseClasses.find { c =>
val cType = c.asClass.toType
cType <:< localTypeOf[Seq[_]] && cType.typeParams.nonEmpty
}.map(t.baseType(_).typeParams.head)
}
```
Also not sure whether types with more than one type parameter are handled
correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
