Github user cloud-fan commented on a diff in the pull request:
    --- Diff: 
    @@ -427,7 +473,14 @@ private[hive] class HiveClientImpl(
       override def alterTable(tableName: String, table: CatalogTable): Unit = 
withHiveState {
    -    val hiveTable = toHiveTable(table)
    +    // getTableOption removes all the Hive-specific properties. Here, we 
fill them back to ensure
    +    // these properties are still available to the others that share the 
same Hive metastore.
    +    // If users explicitly alter these Hive-specific properties through 
ALTER TABLE DDL, we respect
    +    // these user-specified values.
    +    val hiveSpecificProps = table.ignoredProperties.filter {
    --- End diff --
    do we really need to do `filter` here? I think the semantic of 
`ignoredProperties` is: ignore these properties in Spark SQL, but get them back 
when saving the metastore

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to