Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16255#discussion_r96110941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -200,6 +200,8 @@ object RemoveAliasOnlyProject extends Rule[LogicalPlan]
{
case plan: Project if plan eq proj => plan.child
case plan => plan transformExpressions {
case a: Attribute if attrMap.contains(a) => attrMap(a)
+ case b: Alias if attrMap.exists(_._1.exprId == b.exprId)
+ && b.child.isInstanceOf[NamedExpression] => b.child
--- End diff --
I know how the failure happens and this can fix it, but I think it's too
hacky and does not catch the root cause.
https://github.com/apache/spark/pull/16255/files#r92348878 easily explains why
the failure happens and how to fix it, can you make other people understand
your fix easily?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
