Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16474#discussion_r96162649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -135,11 +135,21 @@ class FileScanRDD(
try {
if (ignoreCorruptFiles) {
currentIterator = new NextIterator[Object] {
- private val internalIter = readFunction(currentFile)
+ private val internalIter = {
+ try {
+ // The readFunction may read files before consuming
the iterator.
+ // E.g., vectorized Parquet reader.
+ readFunction(currentFile)
+ } catch {
+ case e @(_: RuntimeException | _: IOException) =>
--- End diff --
yeah, I have this concern too in the pr description.
One problem is the error message is varying across data sources. To list
all error messages here looks not a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
