Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2263#issuecomment-54922757
@marmbrus those files are just a hint for users if they want to change some
of the default settings. Probably not everybody knows what files exactly they
should put under the folder `conf/`
e.g.
`hive-log4j.properties.template` => `hive-log4j.properties` (not
`log4j.properties` see
`https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala#L81`)
`hive-site.xml.template` is for people familiar with `Shark`, they probably
confused with the Hive `dependency` means. In `Shark`, `Hive` is also required
to be installed, and the `hive-site.xml` is placed under `$HIVE/conf`.
`configuration.xsl` is the xml style file for display the `hive-site.xml`
on browser.(http://www.w3.org/Style/XSL/WhatIsXSL.html)
I agree it's probably more clutter if we add those 3 files, but at least we
should keep the `hive-log4j.properties.template`, or we have to change the code
`SparkSQLCLIDriver.scala` to load `log4j.properties` instead of the
`hive-log4j.properties`. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
