Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96294261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1621,9 +1621,11 @@ class Analyzer(
/** Extracts a [[Generator]] expression and any names assigned by
aliases to their output. */
private object AliasedGenerator {
- def unapply(e: Expression): Option[(Generator, Seq[String])] = e
match {
- case Alias(g: Generator, name) if g.resolved => Some((g, name ::
Nil))
- case MultiAlias(g: Generator, names) if g.resolved => Some(g,
names)
+ def unapply(e: Expression): Option[(Generator, Seq[String],
Boolean)] = e match {
--- End diff --
document what the return value means (especially that boolean value, but
also the Seq[String] that's preexisting)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]