Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16517#discussion_r96316695
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -86,6 +86,47 @@ class DetermineHiveSerde(conf: SQLConf) extends
Rule[LogicalPlan] {
}
}
+class HiveAnalysis(session: SparkSession) extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan
resolveOperators {
+ case InsertIntoTable(table: MetastoreRelation, partSpec, query,
overwrite, ifNotExists)
+ if hasBeenPreprocessed(table.output,
table.partitionKeys.toStructType, partSpec, query) =>
+ InsertIntoHiveTable(table, partSpec, query, overwrite, ifNotExists)
+
+ case CreateTable(tableDesc, mode, Some(query)) if
DDLUtils.isHiveTable(tableDesc) =>
+ // Currently `DataFrameWriter.saveAsTable` doesn't support the
Append mode of hive serde
+ // tables yet.
+ if (mode == SaveMode.Append) {
+ throw new AnalysisException(
+ "CTAS for hive serde tables does not support append semantics.")
+ }
+
+ val dbName =
tableDesc.identifier.database.getOrElse(session.catalog.currentDatabase)
+ CreateHiveTableAsSelectCommand(
+ tableDesc.copy(identifier = tableDesc.identifier.copy(database =
Some(dbName))),
+ query,
+ mode == SaveMode.Ignore)
+ }
+
+ /**
+ * Returns true if the [[InsertIntoTable]] plan has already been
preprocessed by analyzer rule
+ * [[PreprocessTableInsertion]]. It is important that this
rule([[HiveAnalysis]]) has to
+ * be run after [[PreprocessTableInsertion]], to normalize the column
names in partition spec and
--- End diff --
This rule is in the same batch with PreprocessTableInsertion, right? If so,
we cannot guarantee that PreprocessTableInsertion will always fire first for a
command before InsertIntoTable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
