Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96359512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,42 @@ import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
/**
+ * Common base class for time zone aware expressions.
+ */
+trait TimeZoneAwareExpression extends Expression {
+
+ /** the timezone ID to be used to evaluate value. */
+ def timeZoneId: Option[String]
+
+ /** Returns a copy of this expression with the specified timeZoneId. */
+ def withTimeZone(timeZoneId: String): TimeZoneAwareExpression
+
+ @transient lazy val timeZone: TimeZone =
TimeZone.getTimeZone(timeZoneId.get)
--- End diff --
how about we make this a `implicit val`? then we can save a lot of code
changes, just need to update `DateTimeUtils.daysToMillis` to `def
daysToMillis(days: Int)(implicit timeZone: TimeZone)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
