Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16594#discussion_r96473148
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
 ---
    @@ -27,6 +27,21 @@ import org.apache.spark.sql.test.SQLTestUtils
      */
     class HiveExplainSuite extends QueryTest with SQLTestUtils with 
TestHiveSingleton {
     
    +  test("show stats in explain command") {
    +    withSQLConf("spark.sql.statistics.showInExplain" -> "false") {
    +      checkKeywordsNotExist(sql(" explain  select * from src "), 
"sizeInBytes", "rowCount")
    --- End diff --
    
    A general style suggestion. Normally, the SQL keywords are using upper case 
in the test cases.
    
    `explain  select * from src` -> `EXPLAIN SELECT * FROM src`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to