Github user jsoltren commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16346#discussion_r96525607
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala 
---
    @@ -157,4 +158,42 @@ class ExecutorsListener(storageStatusListener: 
StorageStatusListener, conf: Spar
         }
       }
     
    +  private def updateExecutorBlacklist(eid: String, isBlacklisted: 
Boolean): Unit = {
    +    val execTaskSummary = executorToTaskSummary.getOrElseUpdate(eid, 
ExecutorTaskSummary(eid))
    +    execTaskSummary.isBlacklisted = isBlacklisted
    +  }
    +
    +  override def onExecutorBlacklisted(executorBlacklisted: 
SparkListenerExecutorBlacklisted)
    +  : Unit = synchronized {
    --- End diff --
    
    I know the Spark project has some style standards. It would be great if 
these could be expressed programmatically, and if failing to meet these 
standards caused a compile time error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to