Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/15018
  
    Thanks for the updates!  This LGTM, except for deciding about negative 
weights.
    
    Responding to your comment above, negative weights are just as problematic 
as 0 weights.  See my comment above "Btw, with negative weights, ..."
    
    I spoke with @mengxr offline, and he does not recall why the original work 
supported negative weights.  I'll wait a few days before merging this to see if 
@zapletal-martin can check out the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to