Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16547#discussion_r96547917
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
---
@@ -335,4 +344,67 @@ class StreamingAggregationSuite extends StreamTest
with BeforeAndAfterAll {
CheckLastBatch((90L, 1), (100L, 1), (105L, 1))
)
}
+
--- End diff --
I prefer to not add this complicated test because:
- TaskContext.get().addTaskCompletionListener has already been tested in
other tests.
- Scala Reflection is not thread-safe in 2.10 and this test may be flaky
since SQL also uses Scala Reflection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
