Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16601#discussion_r96550717
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala ---
    @@ -31,12 +31,15 @@ final private[streaming] class DStreamGraph extends 
Serializable with Logging {
       private val inputStreams = new ArrayBuffer[InputDStream[_]]()
       private val outputStreams = new ArrayBuffer[DStream[_]]()
     
    +  val inputStreamNameAndID = new ArrayBuffer[(String, Int)]()
    --- End diff --
    
    nit: change it to `@volatile private var inputStreamNameAndID: Seq[(String, 
Int)] = Nil` and just set it in `start`. Don't expose a mutable ArrayBuffer to 
the caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to