Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16621#discussion_r96565694
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
---
    @@ -513,8 +514,10 @@ class SQLQuerySuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton {
           isDataSourceTable: Boolean,
           format: String,
           userSpecifiedLocation: Option[String] = None): Unit = {
    -    val relation = EliminateSubqueryAliases(
    -      sessionState.catalog.lookupRelation(TableIdentifier(tableName)))
    +    var relation: LogicalPlan = null
    +    withSQLConf(HiveUtils.CONVERT_METASTORE_PARQUET.key -> "false") {
    --- End diff --
    
    I checked the test cases. `ORC` has the same issue, but the default value 
is `false` currently. Thus, I think we should set `CONVERT_METASTORE_ORC` to 
`false` too, in case we change the default value of `CONVERT_METASTORE_ORC` in 
the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to