Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16308
I went through all of the changes, LGTM overall, left some minor comments.
My main concern is, the newly added tests in `DateFunctionsSuite` are very
hard to reason about the expected result, can you add some comments to explain
them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
