Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96707275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("1.4.0") (
val numFeatures = oldDataset.first().features.size
val boostingStrategy =
super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification)
- val instr = Instrumentation.create(this, oldDataset)
+ val numClasses = 2
+ if (isDefined(thresholds)) {
+ require($(thresholds).length == numClasses,
this.getClass.getSimpleName +
+ ".train() called with non-matching numClasses and
thresholds.length." +
+ s" numClasses=$numClasses, but thresholds has length
${$(thresholds).length}")
+ }
+
+ val instr = org.apache.spark.ml.util.Instrumentation.create(this,
oldDataset)
instr.logParams(params: _*)
instr.logNumFeatures(numFeatures)
instr.logNumClasses(2)
--- End diff --
Log using the 'numClasses' val defined above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
