Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r96910555
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor(
setTaskFinishedAndClearInterruptStatus()
execBackend.statusUpdate(taskId, TaskState.FAILED,
ser.serialize(reason))
+ case t: Throwable if task.context.fetchFailed.isDefined =>
+ // tbere was a fetch failure in the task, but some user code
wrapped that exception
+ // and threw something else. Regardless, we treat it as a fetch
failure.
+ val reason = task.context.fetchFailed.get.toTaskFailedReason
+ setTaskFinishedAndClearInterruptStatus()
+ execBackend.statusUpdate(taskId, TaskState.FAILED,
ser.serialize(reason))
--- End diff --
do you mean the msg I added about "TID ${taskId} completed successfully
though internally it encountered unrecoverable fetch failures!"? I wouldn't
think we'd want to log anything special here. I'm trying to make this a
"normal" code path. The user is allowed to allowed to do this. (sparksql
already does.)
we could log a warning, but then this change should be accompanied by
auditing the code and making sure we never do this ourselves.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
