GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/16669
[SPARK-16101][SQL] Refactoring CSV read path to be consistent with JSON
data source
## What changes were proposed in this pull request?
This PR refactors CSV read path to be consistent with JSON data source. It
makes the methods in classes have consistent arguments with JSON ones.
`UnivocityParser` and `JacksonParser`
``` scala
private[csv] class UnivocityParser(
schema: StructType,
requiredSchema: StructType,
options: CSVOptions) extends Logging {
...
def parse(input: String): Seq[InternalRow] = {
...
```
``` scala
class JacksonParser(
schema: StructType,
columnNameOfCorruptRecord: String,
options: JSONOptions) extends Logging {
...
def parse(input: String): Option[InternalRow] = {
...
```
These allow parsing an iterator (`String` to `InternalRow`) as below for
both JSON and CSV:
```scala
iter.flatMap(parser.parse)
```
## How was this patch tested?
Existing tests should cover this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-16101-read
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16669.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16669
----
commit 28258f7f01790a8898f43d062ebb7f8e10158a47
Author: hyukjinkwon <[email protected]>
Date: 2017-01-21T14:20:25Z
Refactoring CSV read path to be consistent with JSON data source
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]